Review main Merged

41771[BUGFIX] Use parse_url to determine absolute urls in ImageService

Frans Saris CR +2 V +2 Normal +87 −1 updated 07/21/15, 14:30

Commit message

Since it is possible to have protocol relative URIs and parse_url
only identifies a hostname once a scheme or scheme relative prefix is
applied, we can check for a hostname here.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Frederic Gaus +1
    • Helmut Hummel +1
  • Verified V +2
    • Wouter Wolters +2
    • Frederic Gaus +1
    • Helmut Hummel +1

Issues 1

Files 2

Review log 9

  1. Frans Saris uploaded patch set 1 07/21/15, 11:50

  2. Helmut Hummel uploaded patch set 2 07/21/15, 13:20

  3. Helmut Hummel voted on patch set 2 CR +1 V +1 07/21/15, 13:20

  4. Helmut Hummel uploaded patch set 3 07/21/15, 13:21

  5. Helmut Hummel voted on patch set 3 CR +1 V +1 07/21/15, 13:21

  6. Frederic Gaus voted on patch set 3 CR +1 V +1 07/21/15, 14:00

  7. Wouter Wolters voted on patch set 3 V +2 CR +2 07/21/15, 14:30

  8. Wouter Wolters commented on patch set 3 07/21/15, 14:30

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 7da56b18e9bf0d0d6a25c58da84b67f17bf19481
  9. Wouter Wolters merged patch set 3 07/21/15, 14:30