Review TYPO3_6-2 Merged

41777[BUGFIX] Use parse_url to determine absolute urls in ImageService

Wouter Wolters CR +2 V +2 Normal +85 −1 updated 07/21/15, 16:58

Commit message

Since it is possible to have protocol relative URIs and parse_url
only identifies a hostname once a scheme or scheme relative prefix is
applied, we can check for a hostname here.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Nicole Hummel +1
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Nicole Hummel +1
    • Susi Moog +1

Issues 1

Files 2

Review log 9

  1. Wouter Wolters uploaded patch set 2 07/21/15, 14:34

  2. Wouter Wolters uploaded patch set 3 07/21/15, 14:35

  3. Wouter Wolters commented on patch set 3 V +1 CR +1 07/21/15, 14:36

    Now without ::class
  4. Nicole Hummel commented on patch set 3 V -1 07/21/15, 15:24

    Travis is failing for PHP 5.3. Will check that now
  5. Nicole Hummel uploaded patch set 4 07/21/15, 15:43

  6. Nicole Hummel voted on patch set 4 CR +1 V +1 07/21/15, 15:45

  7. Susi Moog voted on patch set 4 CR +1 V +1 07/21/15, 16:18

  8. Christian Kuhn voted on patch set 4 CR +2 V +2 07/21/15, 16:58

  9. Christian Kuhn merged patch set 4 07/21/15, 16:58