Review main Merged

41854[BUGFIX] Fix prototype leftover in FlexFormSectionContainer

Wouter Wolters CR +2 V +2 Easy +1 −1 updated 07/24/15, 05:42

Commit message

Use insertAfter instead of Insertion.Bottom

Review

  • Code review CR +2
    • Georg Ringer +2
    • Susi Moog +1
  • Verified V +2
    • Georg Ringer +2
    • Susi Moog +1

Issues 1

Files 1

Review log 6

  1. Wouter Wolters uploaded patch set 1 07/22/15, 21:11

  2. Susi Moog voted on patch set 1 CR +1 V +1 07/23/15, 08:51

  3. Markus Klein commented on patch set 1 07/23/15, 10:37

    FlexFormSectionContainer.php:119

    wouldn't quoteJS() fit much better here?
  4. Wouter Wolters commented on patch set 1 07/23/15, 18:17

    FlexFormSectionContainer.php:119 Reply

    I don't change this behaviour here. This was already this way.
  5. Georg Ringer voted on patch set 1 CR +2 V +2 07/24/15, 05:42

  6. Georg Ringer merged patch set 1 07/24/15, 05:42