Review main Merged

41937[TASK] Use GU::hmac() instead of encryption key in FileWriter

Anja Leichsenring CR +2 V +2 Easy +2 −2 updated 07/25/15, 07:03

Commit message

There is a potential attack to get hold of a secret encryption key
if such key is hashed with a single hash function and a small additional
string. So if you want to include the encryption key in an hash, you need
to *ALWAYS* use GeneralUtility::hmac() and not any different hash function.

Additionally, don't mention AdditionalConfiguration as place for config
manipulation, as it is considered a hack from core point of view
(see comment #52705).

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2