Review main Merged

41981[BUGFIX] Ensure jQuery is loaded as well when loading the Lang module

Markus Klein CR +2 V +2 Easy +6 −4 updated 07/29/15, 14:56

Commit message

If we forcefully load the JS Lang-module, which depends on jQuery, we
have to ensure that jQuery is requested as well, otherwise the dependency
of the Lang-module fails.

Note that jQuery is never loaded via requireJS. jQuery must be explicitly added
by calling  the loadJquery method of PageRenderer. jQuery itself registers as
an AMD module and can then be used as dependency by other AMD modules.

We therefore also remove the (completely useless) path definition in the
requireJS configuration.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2