Review main Merged

42001[TASK] Replace spinner in extension upload form with iconfont

Benjamin Kott CR +2 V +2 Easy +1 −14 updated 07/27/15, 21:08

Commit message

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Tomas Norre Mikkelsen +1
  • Verified V +2
    • Wouter Wolters +2
    • Tomas Norre Mikkelsen +1

Issues 1

Files 4

Review log 6

  1. Benjamin Kott uploaded patch set 1 07/27/15, 19:31

  2. Wouter Wolters voted on patch set 1 V +1 CR +1 07/27/15, 19:36

  3. Tomas Norre Mikkelsen voted on patch set 1 V +1 CR +1 07/27/15, 19:36

  4. Wouter Wolters voted on patch set 1 V +2 CR +2 07/27/15, 19:41

  5. Wouter Wolters merged patch set 1 07/27/15, 19:41

  6. Felix Kopp commented on patch set 2 07/27/15, 21:08

    .spinner was removed also for extension authors - this patch is breaking. Any plans to deliver a replacement for ext authors? When all extension authors must use fa- syntax now (which I don't find suitable) there should be a rest file for please. Or we says: spinner element from core is gone. I guess breaking/removal is better than pointing to fa- syntax.