Review main Merged

42071[BUGFIX] displayCond in Flexform sheets

Andreas Wolf CR +2 V +2 Easy +8 −6 updated 07/29/15, 11:19

Commit message

This actually fixes two independent bugs:

1) The condition matcher could not access information from another
sheet, because only the current sheet’s data was handed over. That is
simply wrong, as no information depending on a sheet name should be used
in the condition (otherwise you could hide the sheet you’re seeing and
never be able to get it back).

2) The field name in the split condition was changed, but the changed
condition was not passed to the condition matcher.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3