Review main Merged

42112[BUGFIX] Make TypoScriptParser sortList more strict

Benni Mack CR +2 V +2 Normal +71 −4 updated 08/06/15, 11:07

Commit message

When calling the := sortList() with a "numeric" modifier
of the TypoScript parser with a string, the sort() method
differs between PHP versions. In order to make this behaviour
more strict, a check is done before the elements are sorted
to only have numeric values in the list, otherwise an Exception
is now thrown.

As this changes behaviour, the test should be excluded for
PHP7 in 6.2, the behaviour cannot be modified in 6.2 without
possibly breaking the output of a Frontend site.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3