Review main Merged

42161[BUGFIX] PSR-7: Do not let legacy code take precedence over HTTP headers

Helmut Hummel CR +2 V +2 Easy +7 −12 updated 07/31/15, 14:16

Commit message

The code to not overwrite regular headers set by PSR-7 response
is obsolete and should be removed. Legacy code does not have access
to the response object, thus the PSR-7 header list would always be empty.

We also do not want to give legacy code precedence here if our code
explicitly sets some headers.
Also make sure that, if legacy code added some headers, which are also
set in the response object (by us), that the headers are not additionally added
but override the legacy headers.

The only exception is the status code header, which we must allow to
be changed from legacy code for the time being.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 1