Review main Merged

42260[BUGFIX] DataHandler: cast value to string in checkValueForInput()

Morton Jonuschat CR +2 V +2 Easy +13 −1 updated 08/05/15, 21:31

Commit message

Explicitly cast the value as a string before using substr() on it.
Otherwise NULL values would be passed to substr(), resulting in a return
value of FALSE. Without MySQL strict mode this has no direct influence
on the further usage of the value as string as the string representation
of FALSE is an empty string. With MySQL strict mode enabled this leads
to errors upon insertion of records into the database as boolean values
get converted to 0/1 respectively.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 3

Files 2