Review main Merged

42279[BUGFIX] Shortcut list (top right) is filled by duplicated entries

Jan Runte CR +2 V +2 Normal +102 −25 updated 08/08/15, 13:34

Commit message

The AjaxShortcut function has no validation of an already existing entry in the
shortcut list before it create a new one. At this case you have multiple
duplicated entries in your shortcut list and that is simply not expected and
makes no sense.

Additional behaviour for "Delete" buttons in the shortcut list:
After clicking a "Delete" action of a shortcut list entry you get a
modal window to confirm. But the gui blocker for the modal window cannot
completely disallow the shortcut buttons outside the modal context. In this case
the zIndex for the "modal" class (with gui blocker) is simply wrong here
(too small).

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3