Review main Merged

42295[FEATURE] Use Symfony Console in CliRequestHandler

Benni Mack CR +2 V +2 Normal +137 −45 updated 08/06/15, 17:29

Commit message

The logic for outputting the default checks when calling cli_dispatch.phpsh is now using Symfony Console showing
colored error messages when entering wrong cliKeys.

The global variable $GLOBALS['MCONF']['name'] which was
mis-used to transfer information between the CLI RequestHandler
and the BackendUser (only when in CLI mode) for authentication
was removed, as all the logic is now available inside the CliRequestHandler and can be resolved there already.

The call "$BE_USER->checkCLIuser()" on every backend request
is now removed and the method itself is now marked for deprecation,
as the same functionality (except for using exceptions instead of fwrite() calls) is now in CliRequestHandler.

The two constants TYPO3_cliKey and TYPO3_cliInclude have
been marked internally as deprecated, as they are not in use
anymore.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5