Review main Merged

42393[TASK] Remove usage of EXT:lang/4.5

Georg Ringer CR +2 V +2 Normal +42 −208 updated 09/25/15, 12:13

Commit message

Migrate the translations to the files where those belong

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Morton Jonuschat +1
  • Verified V +2
    • Andreas Kienast +2
    • Morton Jonuschat +1

Issues 1

Files 5

Review log 13

  1. Georg Ringer uploaded patch set 1 08/07/15, 19:18

  2. Morton Jonuschat commented on patch set 1 CR -1 08/07/15, 19:40

    Reading some of the texts feels weird due to the unusual capitalization of words. „Page Title“ for example isn't a proper noun and should be spelled as „page title“. The same is true for a few other things

    locallang_csh_pages.xlf:10

    Missing leading single quote?

    locallang_csh_pages.xlf:40

    Another use of the page title...

    locallang_csh_pages.xlf:81

    Double blank

    locallang_csh_pages.xlf:82

    Inconsistent use of TSConfig vs TSconfig througout the document
  3. Xavier Perseguers commented on patch set 1 08/08/15, 06:52

    locallang_csh_pages.xlf:52

    The Page Type...
  4. Andreas Kienast commented on patch set 1 09/25/15, 06:34

    I'd keep the "Page Title", as it refers to a field in the backend with exactly this label.
  5. Andreas Kienast uploaded patch set 2 09/25/15, 06:35

  6. Andreas Kienast uploaded patch set 3 09/25/15, 06:41

  7. Morton Jonuschat uploaded patch set 4 09/25/15, 06:58

  8. Morton Jonuschat voted on patch set 4 CR +1 V +1 09/25/15, 06:58

  9. Andreas Kienast voted on patch set 4 CR +1 V +1 09/25/15, 06:59

  10. Andreas Kienast voted on patch set 4 CR +2 V +2 09/25/15, 08:47

  11. Andreas Kienast merged patch set 4 09/25/15, 08:47

  12. Chris topher commented on patch set 5 09/25/15, 12:08

    This change definitely is the right decision! The same problem is also still present in typo3/sysext/context_help/Resources/Private/Language/4.5. It would be great, if this could be solved as well!
  13. Wouter Wolters commented on patch set 5 09/25/15, 12:13

    Is on our big TODO list :-)