Review main Abandoned

42680Revert "[BUGFIX] Reestablish DB connection in long-running tasks"

Helmut Hummel CR 0 V 0 Easy +7 −13 updated 08/17/15, 20:13

Commit message

This reverts commit 361836d87935b9eb24d95c41c191825dd849d72e.


AND makes a different proposal how to fix this issue

Review

  • Code review CR 0
  • Verified V 0

Files 2

Review log 6

  1. Helmut Hummel uploaded patch set 1 08/17/15, 12:27

  2. Helmut Hummel updated the commit message in patch set 2 08/17/15, 12:38

  3. Stephan Großberndt commented on patch set 2 08/17/15, 12:42

    DatabaseConnection.php:1570

    remove comment
  4. Stefan Neufeind commented on patch set 2 08/17/15, 12:50

    imho the revert itself should just do that - and not introduce other changes ... in case you prefer to revert instead of a followup
  5. Stefan Neufeind commented on patch set 2 CR -1 08/17/15, 13:07

    I fear you might introduce a possible slowdown here by forcing ping() to be executed before every query. Why not leave it to checking the isConnected-property before queries etc. to avoid overhead?
  6. Helmut Hummel abandoned the change 08/17/15, 20:13