Review main Merged

42838[TASK] Reduce PageLayoutController and PageLayoutView dependencies

Oliver Hader CR +2 V +2 Normal +112 −112 updated 09/17/15, 21:16

Commit message

This is a follow-up to #68395 to reduce complexity and exposed
public API of that change.

Even if class components have the names "controller" and "view",
which implies an underlying MVC-stack, the PageLayout components
are far from using the pattern. That's why it's quite fine to put
processing logic to the place where it makes most sense and where
dependencies and cross-calls to other objects are kept low.

This change is only about refactoring and reducing the public API
in terms of information hiding and encapsulation. Besides that
the $languagesInColumnCache class variable was defined but never
use - which is changed now as well. Further flaws concerning
proper record selection are part of another change.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 3