Review main Merged

42904[TASK] Remove data processing trait in favor of object

Helmut Hummel CR +2 V +2 Normal +174 −12 updated 09/23/15, 10:25

Commit message

The introduced DataProcessingTrait isn't exactly a good prototype
for Trait usage.

It incorporates functionality that isn't easily testable,
it is impossible to provide different implementations as the trait
is directly bound to the class with its concrete implementation.

Use a composite object instead for this functionality.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5