Review main Merged

42986[TASK] Functional tests: Enable MySQL strict mode / data validation

Morton Jonuschat CR +2 V +2 Easy +1 −0 updated 06/13/16, 15:09

Commit message

Enable SQL mode options that force MySQL to be more strict and not
allow legacy defaults which truncate data, accept invalidate dates
or silently change values on INSERT/UPDATE.

STRICT_ALL_TABLES: Strict SQL mode for all tables, reject invalid data
ERROR_FOR_DIVISION_BY_ZERO: Division by zero produces an error
NO_AUTO_VALUE_ON_ZERO: Only NULL generates the next auto_incroment number
NO_ENGINE_SUBSTITUTION: No automatic substitution of unavailable engines
NO_ZERO_DATE: Don't treat '0000-00-00' as a valid date
NO_ZERO_IN_DATE: Dates with zero parts are not permitted
ONLY_FULL_GROUP_BY: Deny invalid use of aggregation functions

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1