Review main Merged

43059[FEATURE] Trigger metadata extraction after file upload

Frans Saris CR +2 V +2 Normal +97 −21 updated 09/07/15, 20:14

Commit message

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
  • Verified V +2
    • Georg Ringer +2
    • Wouter Wolters +1

Issues 1

Files 6

Review log 18

  1. Frans Saris uploaded patch set 1 09/05/15, 20:08

  2. Frans Saris commented on patch set 1 09/05/15, 20:24

    This can easily be tested with any metadata extractor found in TER or https://review.typo3.org/#/c/41800 (add a youtube video and check if title, author, width and height are set)
  3. Philipp Gampe voted on patch set 1 CR +1 09/05/15, 21:03

  4. Philipp Gampe commented on patch set 1 V -1 CR -1 09/05/15, 21:17

    ResourceStorage.php:1219

    what is this?
  5. Frans Saris commented on patch set 1 09/05/15, 21:39

    ResourceStorage.php:1219 Reply

    cool new stuff from another patch :) will push a new patch
  6. Frans Saris uploaded patch set 2 09/05/15, 21:44

  7. Philipp Gampe voted on patch set 2 CR +1 09/05/15, 21:47

  8. Philipp Gampe commented on patch set 2 09/06/15, 00:25

    can't test, because meta extraction is broken for me, including indexing and reference index. Seems like deleting files directly in the filesystem still makes TYPO3 choke beyond recovery.
  9. Philipp Gampe commented on patch set 2 V +1 09/06/15, 00:35

    ended up deleting all missing=1 from database :(
  10. Stephan Großberndt commented on patch set 2 09/07/15, 17:37

    Feature-56726-TriggerMetadataExtractionAfterFileUpload.rst:8

    two spaces
  11. Frans Saris uploaded patch set 3 09/07/15, 19:20

  12. Frans Saris commented on patch set 2 09/07/15, 19:20

    Feature-56726-TriggerMetadataExtractionAfterFileUpload.rst:8 Reply

    Done
  13. Georg Ringer voted on patch set 3 CR +1 V +1 09/07/15, 19:24

  14. Wouter Wolters commented on patch set 3 CR -1 09/07/15, 20:05

    The RST contains several wrong wordings, will fix them.

    Feature-56726-TriggerMetadataExtractionAfterFileUpload.rst:12

    "to have to" is not correct IMO fileUpload is not a word.
  15. Wouter Wolters uploaded patch set 4 09/07/15, 20:10

  16. Wouter Wolters voted on patch set 4 V +1 CR +1 09/07/15, 20:10

  17. Georg Ringer voted on patch set 4 CR +2 V +2 09/07/15, 20:14

  18. Georg Ringer merged patch set 4 09/07/15, 20:14