Review main Merged

43278[TASK] Streamline select field value handling

Alexander Stehlik CR +2 V +2 Hard +473 −325 updated 09/15/15, 06:38

Commit message

The TcaSelectValues form data provider is merged in the
TcaSelectItems provider.

The possible select items are classified in dynamic items that
come from a foreign_table and static items that come from TCA,
PageTS etc.

The value for single item select fields (the default) will not
be processed because the handling of invalid values will currently
be done by the select field element renderer.

If the values from a multi value select field come from statically
defined items (e.g. items directly added in the TCA) the value will
always be added to the list of selected values.

If the values comes from dynamic select items from a database
relation the select values will only be added when they were
validated by the RelationHandler.

Finally the selected values are parsed by array_unique to prevent
duplicate entries.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5