43334[TASK] Use binary notation for JsConfirmation values
Commit message
Review
-
Code review CR +2
- Andreas Kienast +2
- Stefan Froemken +1
-
Verified V +2
- Andreas Kienast +2
- Stefan Froemken +1
Issues 1
Files 1
Review log 6
-
Mathias Brodala uploaded patch set 1 09/15/15, 13:52
-
Nicole Hummel commented on patch set 1 09/15/15, 16:52
TBH for me this isn't really more readable -
Mathias Brodala commented on patch set 1 09/18/15, 07:25
The idea was to make it easier to understand the binary check peformed in BackendUserAuthentication. -
Stefan Froemken commented on patch set 1 CR +1 V +1 09/21/15, 10:22
The variables and documentation talks about bitmask and that is 0 and 1 and not decimal. So for me it's OK. -
Andreas Kienast voted on patch set 1 CR +2 V +2 09/23/15, 13:25
-
Andreas Kienast merged patch set 1 09/23/15, 13:25