Review main Merged

43488[BUGFIX] Use proper fieldname to check result in getFirstTimeValueForRecord()

Georg Ringer CR +2 V +2 Easy +2 −3 updated 09/23/15, 19:48

Commit message

The method builds a query using "as". Therefore the result needs to be checked
by using the same name.

Review

  • Code review CR +2
    • Nicole Hummel +2
    • Sascha Egerer +1
    • Stefan Froemken +1
    • Michael Oehlhof +1
    • Helmut Hummel +1
  • Verified V +2
    • Nicole Hummel +2
    • Stefan Froemken +1
    • Helmut Hummel +1

Issues 1

Files 1

Review log 14

  1. Georg Ringer uploaded patch set 1 09/23/15, 04:52

  2. Stefan Froemken commented on patch set 1 V +1 09/23/15, 08:26

    You can test that with a line like that in TS: config.cache.38 = tx_sfcategory_domain_model_car:42

    TypoScriptFrontendController.php:4609

    Can we remove that line, since loadTCA isn't valid anymore?

    TypoScriptFrontendController.php:4616

    Can we change that to !== NULL?
  3. Georg Ringer uploaded patch set 2 09/23/15, 12:36

  4. Georg Ringer commented on patch set 2 09/23/15, 12:36

    i don't want to change more than needed. is_null works perfectly and is also widely used in the core
  5. Stefan Froemken voted on patch set 2 CR +1 V +1 09/23/15, 12:39

  6. Michael Oehlhof voted on patch set 2 CR +1 09/23/15, 19:15

  7. Sascha Egerer voted on patch set 2 CR +1 09/23/15, 19:21

  8. Helmut Hummel voted on patch set 2 CR +2 V +2 09/23/15, 19:30

  9. Helmut Hummel commented on patch set 2 CR -1 V -1 09/23/15, 19:32

    wait a bit
  10. Nicole Hummel commented on patch set 2 09/23/15, 19:43

    TypoScriptFrontendController.php:4613

    current timestamp
  11. Helmut Hummel voted on patch set 2 CR +1 V +1 09/23/15, 19:47

  12. Nicole Hummel voted on patch set 2 CR +1 V +1 09/23/15, 19:47

  13. Nicole Hummel voted on patch set 2 CR +2 V +2 09/23/15, 19:48

  14. Nicole Hummel merged patch set 2 09/23/15, 19:48