Review main Abandoned

43563[FEATURE] Include "FIND_IN_SET()" option in QueryGenerator

Philipp Kerling CR 0 V 0 Easy +19 −0 updated 12/09/15, 15:41

Commit message

The QueryGenerator missed the option to filter records with the
"FIND_IN_SET()" function, which is needed e.g. for selecting all frontend
users of a specific group.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 13

  1. Philipp Kerling uploaded patch set 1 09/25/15, 08:59

  2. Andreas Kienast commented on patch set 1 CR -1 09/25/15, 09:03

    Hi Philipp, thank you for your patch. Please be aware that Features require a ReST document describing the feature: https://forger.typo3.org/standard/rst Also, your commit message misses the line "Releases: master".
  3. Philipp Kerling uploaded patch set 2 09/25/15, 09:17

  4. Andreas Kienast updated the commit message in patch set 3 09/25/15, 09:27

  5. Andreas Kienast voted on patch set 3 CR +1 09/25/15, 09:27

  6. Oliver Hader uploaded patch set 4 10/09/15, 00:21

  7. Georg Ringer voted on patch set 4 CR +1 V +1 11/21/15, 17:45

  8. Josef Glatz voted on patch set 4 CR +1 11/23/15, 10:16

  9. Morton Jonuschat commented on patch set 4 CR -1 11/27/15, 09:53

    This is very MySQL specific and alternatives to FIND_IN_SET() are hard to get right on other DBMS. As a workaround a few carefully crafted LIKE statements should be possible for the given use case.
  10. Philipp Kerling commented on patch set 4 11/27/15, 13:54

    @Morton Jonuschat: As far as I understand it, the TYPO3 core is written with MySQL in mind. Although the dbal extension exists, I think it is fine to assume that the majority of users run TYPO3 with MySQL. I understand that I can get around FIND_IN_SET if I carefully craft the query, but if I wanted to do that by myself, there really would be no reason to use the query generator. I assumed that the query generator was supplied specifically to avoid having to hand-craft SQL queries like this, which most users without technological background would not be able to do anyway.
  11. Morton Jonuschat commented on patch set 4 12/02/15, 21:27

    There's been a lot of work done to make the core less reliant on MySQL specifics. FIND_IN_SET() is one of the last relics in that regard. I would prefer not introducing it in more places now and instead focus on getting rid of it altogether in the long run. As a feature it won't get into 7 anyhow, so my preference would be to work on migrating fe_user/fe_groups relations to a real M:N setup for 8
  12. Oliver Hader commented on patch set 4 CR -1 12/03/15, 00:13

    Like Morton pointed out already... resolving and deprecating CSV lists is a topic for TYPO3 CMS 8
  13. Georg Ringer abandoned the change 12/09/15, 15:41

    see forge