Review main Merged

43564[BUGFIX] Fix validation for objects of the same type

Stephan Großberndt CR +2 V +2 Easy +2 −2 updated 09/25/15, 11:37

Commit message

The patch http://review.typo3.org/40693 introduced a regression by
replacing a count() check on a countable object with a !empty() check,
which lead to failing validations for objects of the same type.

Since getBaseValidatorConjunction() returns either an object or NULL
check for NULL instead and make the countable call explicit.

getBaseValidatorConjunction() doesn't have a second parameter in the
backport, thus remove that parameter.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 1