Review main Merged

43669[BUGFIX] Remove trailing slash from autoload information files

Helmut Hummel CR +2 V +2 Easy +7 −3 updated 10/01/15, 04:53

Commit message

If an extension defines a classmap in ext_emconf.php or composer.json which points
to a file instead of a directory. The relative path calculation adds
a trailing slash to the file name, which breaks the class loading.

This trailing slash needs to be removed. As a bonus the obsolete trailing slash
is also removed from directories.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Daniel Goerz +1
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2
    • Georg Ringer +2
    • Daniel Goerz +1
    • Wouter Wolters +1
    • Christian Kuhn +1

Issues 1

Files 3

Review log 9

  1. Helmut Hummel uploaded patch set 1 09/30/15, 18:27

  2. Wouter Wolters voted on patch set 1 V +1 CR +1 09/30/15, 18:32

  3. Daniel Goerz voted on patch set 1 CR +1 V +1 09/30/15, 18:36

  4. Christian Kuhn uploaded patch set 2 09/30/15, 19:06

  5. Christian Kuhn commented on patch set 2 CR +1 V +1 09/30/15, 19:07

    rebased, no code change.
  6. Wouter Wolters voted on patch set 2 V +1 CR +1 09/30/15, 19:23

  7. Daniel Goerz voted on patch set 2 CR +1 V +1 09/30/15, 20:32

  8. Georg Ringer voted on patch set 2 CR +2 V +2 10/01/15, 04:53

  9. Georg Ringer merged patch set 2 10/01/15, 04:53