Review main Merged

43755[TASK] FormEngine inline refactoring

Christian Kuhn CR +2 V +2 Nightmare +1796 −1098 updated 10/08/15, 15:40

Commit message

FormEngine splits in two parts: Data compilation and preparation
and rendering.

The patch separates the inline related data preparation out
of the render containers and moves it into the data provider.
TcaInline provider now resolves and compiles children and adds them
to processedTca[columns][$field][children], so InlineControlContainer
can just loop over them to render children.

InlineRecordContainer, the second inline container that takes
care of rendering single children records now no longer receives
the full parent data, but only the specific child data array it should
render. This leads to better encapsulation and allows some future
performance improvements.

While the inline stuff is still a very complex thing, this last
main structural FormEngine change takes the opportunity to comment
further details and dependencies and it simplifies the structures
by better separation of concerns.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 20