Review main Merged

43930[BUGFIX] Unused variable assigned twice in one function call

Benni Mack CR +2 V +2 Easy +2 −2 updated 10/09/15, 12:00

Commit message

The refactoring of the Element Browser and Record List introduced
a second "unused" variable which is named the same. This is not
allowed in PHP7, thus resulting in a PHP error in the unit tests.

Review

  • Code review CR +2
    • Alexander Opitz +2
    • Wouter Wolters +1
    • Andreas Kienast +1
  • Verified V +2
    • Alexander Opitz +2
    • Wouter Wolters +1
    • Andreas Kienast +1

Issues 1

Files 1

Review log 11

  1. Benni Mack uploaded patch set 1 10/09/15, 11:48

  2. Markus Klein voted on patch set 1 CR +2 10/09/15, 11:49

  3. Markus Klein voted on patch set 1 V +2 10/09/15, 11:52

  4. Alexander Opitz voted on patch set 1 V +1 CR +1 10/09/15, 11:52

  5. Andreas Kienast commented on patch set 1 10/09/15, 11:54

    AbstractRecordList.php:212

    $_2?
  6. Andreas Kienast uploaded patch set 2 10/09/15, 11:57

  7. Andreas Kienast voted on patch set 2 CR +1 V +1 10/09/15, 11:57

  8. Alexander Opitz voted on patch set 2 V +1 CR +1 10/09/15, 11:57

  9. Wouter Wolters voted on patch set 2 V +1 CR +1 10/09/15, 11:57

  10. Alexander Opitz voted on patch set 2 V +2 CR +2 10/09/15, 12:00

  11. Alexander Opitz merged patch set 2 10/09/15, 12:00