Review main Merged

43973[BUGFIX] Repair System Information Panel extendibility

Patrick Schriner CR +2 V +2 Normal +47 −26 updated 04/01/16, 12:03

Commit message

Contrary to the documentation given for extending the System Information
Panel via SignalSlot only a single item can be added for each slot due to
improper use of the SignalSlot pattern. The return value of both signals is
assumed to be only one item. This patch passes the Controller as an argument
and adds two methods to add items.

The two signals were marked as internal, so this is not considered
a breaking patch.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2