Review main Merged

4405[BUGFIX] "New record" button in Template mod broken

Jigal van Hemert CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

Recent browsers follow HTML5 standards for submitting image input
elements. The result is that the name of the image input element is
not submitted anymore, only the name with the x and y coordinates.
Checking for createExtension_x or createExtension being set makes the
button work again.

Review

  • Code review CR +2
    • Susi Moog +2
    • Christian Kuhn +1
  • Verified V +2
    • Susi Moog +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 8

  1. Xavier Perseguers commented on patch set 1 08/20/11, 09:46

    (2 inline comments)
    coordinates, not co-ordinates
    Please use 4.6 instead of master. When 4.7 is the master, we will read the message and wonder why it was not part of 4.6 but was part of 4.5...
  2. Jigal van Hemert commented on patch set 1 08/20/11, 09:46

    (2 inline comments)

    Reply

    Done

    Reply

    Done
  3. Christian Kuhn commented on patch set 2 08/20/11, 09:46

    Verified; Looks good to me, but someone else must approve
  4. Jigal van Hemert uploaded patch set 2 08/20/11, 09:46

  5. Mr. Jenkins commented on patch set 1 08/20/11, 09:46

  6. Mr. Jenkins commented on patch set 2 08/20/11, 09:46

  7. Susi Moog commented on patch set 2 V 0 08/20/11, 09:46

    by team member; Looks good to me, approved
  8. Susi Moog merged patch set 2 08/20/11, 09:46