Review main Merged

44077[BUGFIX] Fix fatal error in PageLayoutController

Georg Ringer CR +2 V +2 Easy +20 −25 updated 10/15/15, 20:34

Commit message

Move the module template initialization where it is clear
that the BE user really has access to the page.

Additionally clean up other mistakes in the code.

Review

  • Code review CR +2
    • Markus Klein +2
    • Daniel Goerz +1
    • Marcus Schwemer +1
  • Verified V +2
    • Markus Klein +2
    • Daniel Goerz +1
    • Marcus Schwemer +1

Issues 1

Files 1

Review log 14

  1. Georg Ringer uploaded patch set 1 10/15/15, 10:45

  2. Andreas Allacher voted on patch set 1 CR +1 V +1 10/15/15, 12:47

  3. Andreas Kienast commented on patch set 1 10/15/15, 12:51

    D other locations need some love, too? For example the EditDocumentController has a similar line, but I'm unsure if such check is required there.
  4. Andreas Allacher commented on patch set 1 10/15/15, 16:51

    @Andreas Fernandez: Will test some other locations tomorroow but probably the will also need a similar change :)
  5. Daniel Goerz voted on patch set 1 CR +1 V +1 10/15/15, 17:17

  6. Markus Klein commented on patch set 1 10/15/15, 18:09

    We passed an empty array in a different patch in case no pageinfo is there. What should it be like?
  7. Markus Klein uploaded patch set 2 10/15/15, 18:23

  8. Markus Klein uploaded patch set 3 10/15/15, 18:26

  9. Markus Klein updated the commit message in patch set 4 10/15/15, 18:27

  10. Markus Klein voted on patch set 4 CR +1 V +1 10/15/15, 18:28

  11. Daniel Goerz voted on patch set 4 CR +1 V +1 10/15/15, 19:03

  12. Marcus Schwemer voted on patch set 4 CR +1 V +1 10/15/15, 20:04

  13. Markus Klein voted on patch set 4 CR +2 V +2 10/15/15, 20:33

  14. Markus Klein merged patch set 4 10/15/15, 20:33