Review main Merged

44135[BUGFIX] Avoid empty "name" attribute on f:form.submit

Claus Due CR +2 V +2 Easy +3 −1 updated 10/22/15, 08:44

Commit message

Empty name attribute causes invalid HTML. Avoiding the
attribute if resolved name of submit button is empty
avoids this invalid HTML.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Daniel Goerz +1
    • Andreas Kienast +1
  • Verified V +2
    • Wouter Wolters +2
    • Daniel Goerz +1

Files 1

Review log 9

  1. Claus Due uploaded patch set 1 10/17/15, 23:50

  2. Claus Due uploaded patch set 2 10/17/15, 23:51

  3. Claus Due uploaded patch set 3 10/17/15, 23:52

  4. Claus Due uploaded patch set 4 10/18/15, 18:26

  5. Wouter Wolters voted on patch set 4 CR +1 10/20/15, 11:29

  6. Andreas Kienast voted on patch set 4 CR +1 10/20/15, 11:30

  7. Daniel Goerz voted on patch set 4 CR +1 V +1 10/20/15, 21:11

  8. Wouter Wolters voted on patch set 4 V +2 CR +2 10/22/15, 08:44

  9. Wouter Wolters merged patch set 4 10/22/15, 08:44