Review main Merged

44138[BUGFIX] Fallback to argument values in f:image/f:media on invalid dimensions

Claus Due CR +2 V +2 Easy +34 −4 updated 11/14/15, 17:42

Commit message

* Check which width/height to use; the ones from arguments or the
  ones returned after image scaling (uses original if different).
* Do not apply the "width" and "height" attributes if resolved
  dimensions are empty.

The effect is that if the ViewHelper is used with dimensions on a
site that does *NOT* support image resizing, rather than output an
invalid tag (with width/height being zero or full size of image)
it now outputs a tag where width/height is set to the (numeric part
of the) value of the width/height arguments.

Long story short: if the server can't scale images the browser can.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 2