Review main Merged

44186[TASK] Drop faulty getIcons() method from "Icons" module

Andreas Kienast CR +2 V +2 Normal +58 −118 updated 10/20/15, 22:04

Commit message

The getIcons() implementation of the Icons RequireJS module is faulty and
leads to issues when fetching cached and uncached icons in the same
request. The method is dropped and all calls against that API are
adjusted.

As the API was introduced a week ago, this change is considered being
not breaking.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 9