Review main Merged

44251[BUGFIX] TCA displayCond with EXT:anExt:LOADED fails

Christian Kuhn CR +2 V +2 Normal +40 −44 updated 10/23/15, 17:40

Commit message

Due to the new condition evaluation construct in FormEngine, the
EXT:anExtension:LOADED display condition is very unfortunate since
the evaluation happens at the end, and depending on the configuration
of affected field, the former data provider may fail fetching data.

This is solved by deprecating this condition since it works contrary
to the "additive" TCA system: Extensions should always add or change
other extensions TCA, but should not have a "negative" dependency
to each other like "Don't do if that extension is loaded".

Core is affected at two places in combination with
static_info_tables. This also lowers the dependency from core
to static_info_tables again, which is not a good thing in
first place.

A patch for static_info_tables adding the fields there is pending.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 4