Review main Merged

44269[BUGFIX] FormEngine: Inline getDynamicTabMenu

Christian Kuhn CR +2 V +2 Normal +86 −101 updated 10/28/15, 15:01

Commit message

getDynamicTabMenu() from DocumentTemplate is one of the last pieces
where FormEngine indirectly calls PageRenderer to load JS stuff
instead of returning those via the return structure of FormEngine.
This leads to missing JS if tabs are added via ajax dom modification
and parent has none yet.
The patch copies parts of the code to the FormEngine, re-uses the
template, but strips the method down to FormEngines need. As a result
getTabMenuId() can be deprecated in DocumentTemplate and removed in
ModuleTemplate. The patch then re-routes other usages of
getDynamicTabMenu from DocumentTemplate to ModuleTemplate, removes
another obsolete parameter in there and deprecates the method in
DocumentTemplate.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 12