Review main Merged

44327[TASK] Improve default template path for FSC

Markus Klein CR +2 V +2 Easy +13 −10 updated 10/28/15, 17:27

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Xavier Perseguers +1
    • Andreas Kienast +1
    • Mathias Brodala +1
  • Verified V +2
    • Christian Kuhn +2
    • Daniel Goerz +1

Issues 1

Files 3

Review log 10

  1. Markus Klein uploaded patch set 1 10/28/15, 08:45

  2. Xavier Perseguers commented on patch set 1 10/28/15, 08:48

    constants.txt:2

    Wondering why we hardcoded those strings in the first place ?!?
  3. Markus Klein commented on patch set 1 10/28/15, 08:49

    constants.txt:2 Reply

    Well, it makes sense to define a default rendering, doesn't it?
  4. Mathias Brodala commented on patch set 1 CR +1 10/28/15, 08:50

    setup.txt:1

    +1 for this alone. ;-)
  5. Daniel Goerz voted on patch set 1 CR +1 V +1 10/28/15, 09:12

  6. Markus Klein commented on patch set 1 10/28/15, 09:24

    works on live already, just to mention. ;-)
  7. Andreas Kienast voted on patch set 1 CR +1 10/28/15, 09:27

  8. Xavier Perseguers commented on patch set 1 CR +1 10/28/15, 09:46

    constants.txt:2 Reply

    was speaking of the hardcoded labels but I opened a ticket :)
  9. Christian Kuhn voted on patch set 1 CR +2 V +2 10/28/15, 17:27

  10. Christian Kuhn merged patch set 1 10/28/15, 17:27