Review main Merged

44354[TASK] Allow to define multiple inlineLocalizeSynchronize commands

Oliver Hader CR +2 V +2 Normal +101 −17 updated 12/07/15, 06:31

Commit message

The inlineLocalizeSynchronize command in DataHandler currently
supports these formats:
* [parent][13][inlineLocalizeSynchronize] = field,14
* [parent][13][inlineLocalizeSynchronize] = field,localize
* [parent][13][inlineLocalizeSynchronize] = field,synchronize

Since the sub-commands "localize" and "synchronize" address the
whole parent scope, the particular definition of a child-id (14
in this case) is only considered for one child-element. Localizing
different children would then result in multiple independent
DataHandler processings.

The scope of this change is to extend the API to define multiple
child-ids and define the proper language, which is currently
determined from the parent-element magically.

The current string configuration format is changed to be an array,
legacy configurations are converted to the new format:

[parent][13][inlineLocalizeSynchronize] = [
  field: name of the parent field,
  language: id of the target language,
  action: either "localize" or "synchronize",
  ids: array of child-ids to be localized [1, 2, 3]
]
Either "action" or "ids" must be defined.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3