Review main Merged

44390[TASK] Remove documentTemplate sections at ElementInformationController

Ruud Silvrants CR +2 V +2 Easy +6 −4 updated 10/30/15, 16:15

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Ruud Silvrants +1
    • Wouter Wolters +1
    • Gernot Schulmeister +1
  • Verified V +2
    • Christian Kuhn +2
    • Ruud Silvrants +1
    • Wouter Wolters +1
    • Gernot Schulmeister +1

Issues 1

Files 1

Review log 21

  1. Ruud Silvrants uploaded patch set 1 10/30/15, 11:08

  2. Ruud Silvrants uploaded patch set 2 10/30/15, 11:09

  3. Ruud Silvrants uploaded patch set 3 10/30/15, 12:02

  4. Ruud Silvrants uploaded patch set 4 10/30/15, 12:22

  5. Gernot Schulmeister commented on patch set 4 CR +1 V +1 10/30/15, 12:34

    tested with content element and file, looks good to me :-)
  6. Wouter Wolters voted on patch set 4 CR +1 10/30/15, 12:41

  7. Christian Kuhn commented on patch set 4 CR -1 10/30/15, 14:26

    ElementInformationController.php:469

    htmlspecialchars for the label pls, section() did that if not explicitely turned off.
  8. Ruud Silvrants uploaded patch set 5 10/30/15, 14:36

  9. Ruud Silvrants commented on patch set 4 10/30/15, 14:37

    ElementInformationController.php:469 Reply

    Done
  10. Wouter Wolters commented on patch set 5 CR -1 10/30/15, 14:39

    Ruud is on it
  11. Ruud Silvrants uploaded patch set 6 10/30/15, 14:43

  12. Wouter Wolters voted on patch set 6 V +1 CR +1 10/30/15, 14:46

  13. Wouter Wolters commented on patch set 6 V 0 CR 0 10/30/15, 14:47

    needs to be lowercase for true
  14. Gernot Schulmeister uploaded patch set 7 10/30/15, 14:55

  15. Wouter Wolters commented on patch set 7 CR -1 10/30/15, 14:58

    please get back to patchset 6 but than with TRUE to lowercase.
  16. Gernot Schulmeister uploaded patch set 8 10/30/15, 15:26

  17. Wouter Wolters voted on patch set 8 V +1 CR +1 10/30/15, 15:31

  18. Ruud Silvrants voted on patch set 8 CR +1 V +1 10/30/15, 15:42

  19. Gernot Schulmeister voted on patch set 8 CR +1 V +1 10/30/15, 15:45

  20. Christian Kuhn voted on patch set 8 CR +2 V +2 10/30/15, 16:15

  21. Christian Kuhn merged patch set 8 10/30/15, 16:15