44390[TASK] Remove documentTemplate sections at ElementInformationController
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Ruud Silvrants +1
- Wouter Wolters +1
- Gernot Schulmeister +1
-
Verified V +2
- Christian Kuhn +2
- Ruud Silvrants +1
- Wouter Wolters +1
- Gernot Schulmeister +1
Issues 1
Files 1
Review log 21
-
Ruud Silvrants uploaded patch set 1 10/30/15, 11:08
-
Ruud Silvrants uploaded patch set 2 10/30/15, 11:09
-
Ruud Silvrants uploaded patch set 3 10/30/15, 12:02
-
Ruud Silvrants uploaded patch set 4 10/30/15, 12:22
-
Gernot Schulmeister commented on patch set 4 CR +1 V +1 10/30/15, 12:34
tested with content element and file, looks good to me :-) -
Wouter Wolters voted on patch set 4 CR +1 10/30/15, 12:41
-
Christian Kuhn commented on patch set 4 CR -1 10/30/15, 14:26
ElementInformationController.php:469htmlspecialchars for the label pls, section() did that if not explicitely turned off. -
Ruud Silvrants uploaded patch set 5 10/30/15, 14:36
-
Ruud Silvrants commented on patch set 4 10/30/15, 14:37
ElementInformationController.php:469ReplyDone -
Wouter Wolters commented on patch set 5 CR -1 10/30/15, 14:39
Ruud is on it -
Ruud Silvrants uploaded patch set 6 10/30/15, 14:43
-
Wouter Wolters voted on patch set 6 V +1 CR +1 10/30/15, 14:46
-
Wouter Wolters commented on patch set 6 V 0 CR 0 10/30/15, 14:47
needs to be lowercase for true -
Gernot Schulmeister uploaded patch set 7 10/30/15, 14:55
-
Wouter Wolters commented on patch set 7 CR -1 10/30/15, 14:58
please get back to patchset 6 but than with TRUE to lowercase. -
Gernot Schulmeister uploaded patch set 8 10/30/15, 15:26
-
Wouter Wolters voted on patch set 8 V +1 CR +1 10/30/15, 15:31
-
Ruud Silvrants voted on patch set 8 CR +1 V +1 10/30/15, 15:42
-
Gernot Schulmeister voted on patch set 8 CR +1 V +1 10/30/15, 15:45
-
Christian Kuhn voted on patch set 8 CR +2 V +2 10/30/15, 16:15
-
Christian Kuhn merged patch set 8 10/30/15, 16:15