Review main Merged

44412[BUGFIX] Suggest wizard does not work on new records

Thomas Maroschik CR +2 V +2 Easy +1 −1 updated 10/31/15, 13:14

Commit message

The suggest wizard gets it's parameters via a POST json
body. Inside there is the current record uid given,
which follows the scheme "NEW{random number}". For whatever
reason the wizard casts this uid to an integer which results
in a 0. The following check for a numeric uid fails in the
case of a new record, as it is always numeric because of the
cast.

This patch removes the cast. No further sanitizing is necessary
as the uid is casted in every further use case where appropriate.

Review

  • Code review CR +2
    • Morton Jonuschat +2
    • Gernot Schulmeister +1
    • Christian Kuhn +1
  • Verified V +2
    • Morton Jonuschat +2
    • Gernot Schulmeister +1
    • Christian Kuhn +1

Issues 1

Files 1

Review log 10

  1. Thomas Maroschik uploaded patch set 1 10/30/15, 15:38

  2. Thomas Maroschik updated the commit message in patch set 2 10/30/15, 15:39

  3. Thomas Maroschik updated the commit message in patch set 3 10/30/15, 15:54

  4. Daniel Goerz commented on patch set 3 10/30/15, 18:02

    This does not fix the issue for suggest wizzard in FLEXFORMS of new but not saved elements. Is it suppose to fix that, too? For TCA suggest wizzard it works.
  5. Michael Oehlhof commented on patch set 3 10/30/15, 20:48

    The first line of the commit message should describe what changed (the new behavior) and not how it works wrong without the patch. In line 4 there is one "there" too much.
  6. Christian Kuhn updated the commit message in patch set 4 10/31/15, 11:45

  7. Christian Kuhn voted on patch set 4 CR +1 V +1 10/31/15, 11:46

  8. Gernot Schulmeister voted on patch set 4 CR +1 V +1 10/31/15, 13:00

  9. Morton Jonuschat voted on patch set 4 V +2 CR +2 10/31/15, 13:14

  10. Morton Jonuschat merged patch set 4 10/31/15, 13:14