44427[TASK] Remove DocumentTemplate sections at TypoScriptTemplateInformationModuleFunctionController
Commit message
Review
-
Code review CR +2
- Jan Helke +2
- Daniel Goerz +1
- Gernot Schulmeister +1
- Michael Oehlhof +1
-
Verified V +2
- Jan Helke +2
- Daniel Goerz +1
- Gernot Schulmeister +1
- Michael Oehlhof +1
Issues 1
Files 1
Review log 10
-
Wouter Wolters uploaded patch set 1 10/30/15, 18:48
-
Michael Oehlhof voted on patch set 1 CR +1 V +1 10/30/15, 20:30
-
Daniel Goerz voted on patch set 1 CR +1 V +1 10/30/15, 22:13
-
Jan Helke voted on patch set 1 CR -1 10/31/15, 11:47
-
Jan Helke commented on patch set 1 10/31/15, 11:48
I have some doubts about the correct HTML replacement. -
Jan Helke commented on patch set 1 10/31/15, 12:07
A lot of divs are on other places and a css class is missing.TypoScriptTemplateInformationModuleFunctionController.php:261I am missing the class="uppercase" here. I am aware that the class is not honored, but we shouldn't change behaviour here.TypoScriptTemplateInformationModuleFunctionController.php:261In the original code, this part is prefixed by a div.TypoScriptTemplateInformationModuleFunctionController.php:261This div does not exist in the original. -
Wouter Wolters commented on patch set 1 10/31/15, 12:12
Jan, this is done exactly the same way all other patches are done by Ruud yesterday!! -
Gernot Schulmeister commented on patch set 1 CR +1 V +1 10/31/15, 12:27
Ruud did not set the divs around the content block, but I think the divs are ok because in sysext\backend\Classes\Template\DocumentTemplate.php Line 1054 also a starting div which often might have not be closed in the old code by sectionEnd() in Line 1074 -
Jan Helke commented on patch set 1 CR +2 V +2 10/31/15, 12:53
Talked to Christian and it was decided, that the changed HTML has less priority than cleaned up PHP code. The module looks alike, so it ok. -
Jan Helke merged patch set 1 10/31/15, 12:53