44500[BUGFIX] Show warning message on regex error in Object Browser
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Daniel Goerz +1
-
Verified V +2
- Stefan Neufeind +2
- Daniel Goerz +1
Issues 1
Files 3
Review log 22
-
Mathias Schreiber uploaded patch set 1 11/03/15, 10:59
-
Andreas Kienast voted on patch set 1 CR +1 V +1 11/03/15, 11:03
-
Markus Klein commented on patch set 1 11/03/15, 11:07
Do I read that correctly that this only is something which is helpful if dev-preset is active? preg_match does not throw execptions -
Mathias Schreiber commented on patch set 1 11/03/15, 11:09
yes -
Markus Klein commented on patch set 1 11/03/15, 11:12
ExtendedTemplateService.php:587@throws missingExtendedTemplateService.php:619What is the type of the exception we receive from preg_match? I suggest to use a more specific exception than one of the most generic exception classes. -
Mathias Schreiber uploaded patch set 2 11/03/15, 11:38
-
Mathias Schreiber commented on patch set 2 11/03/15, 11:39
it's a warning. -
Mathias Schreiber uploaded patch set 3 11/03/15, 11:49
-
Mathias Schreiber uploaded patch set 4 11/03/15, 11:50
-
Markus Klein voted on patch set 4 CR +1 V +1 11/03/15, 11:52
-
Christian Kuhn commented on patch set 4 11/03/15, 12:29
TypoScriptTemplateModuleController.php:105not a fan of this one ... let us at least mark it as @internal ... -
Helmut Hummel commented on patch set 1 11/03/15, 12:50
ExtendedTemplateService.php:607is it really a feature that $searchString can be a regex part? if not, I'd rather properly quote it here and disallow regular expressionsExtendedTemplateService.php:618a PHP warning is not always converted into an exception. it depends on configuration whether or not this happens. we cannot just assume so.TypoScriptTemplateModuleController.php:107no need to expose thisTypoScriptTemplateObjectBrowserModuleFunctionController.php:421flash messages can be created and added without the module template being exposed -
Helmut Hummel commented on patch set 4 CR -1 11/03/15, 12:51
TypoScriptTemplateModuleController.php:105Replythis must not be exposed. and there is no need for it eitherTypoScriptTemplateObjectBrowserModuleFunctionController.php:414I think this still does not throw exceptions in all cases -
Helmut Hummel uploaded patch set 5 11/03/15, 14:27
-
Helmut Hummel uploaded patch set 6 11/03/15, 14:33
-
Nicole Hummel commented on patch set 6 11/03/15, 14:40
TypoScriptTemplateObjectBrowserModuleFunctionController.php:419use "use" statementTypoScriptTemplateObjectBrowserModuleFunctionController.php:421We should use the error code to be able to translate the message -
Helmut Hummel commented on patch set 6 11/03/15, 14:42
TypoScriptTemplateObjectBrowserModuleFunctionController.php:421Replyyes, fine with me. I only cleaned up the architecture of the fix (removing dependencies to config and classes). But it would of course be nice to have a translated message here (like the other messages emitted by this class) -
Daniel Goerz commented on patch set 6 CR -1 11/03/15, 20:40
on it -
Daniel Goerz uploaded patch set 7 11/03/15, 20:42
-
Daniel Goerz voted on patch set 7 CR +1 V +1 11/03/15, 20:42
-
Stefan Neufeind voted on patch set 7 V +2 CR +2 11/03/15, 21:31
-
Stefan Neufeind merged patch set 7 11/03/15, 21:31