Review main Merged

44570[BUGFIX] FormEngine: Fix keepItems, addItems and removeItems handling

Morton Jonuschat CR +2 V +2 Hard +337 −3 updated 11/06/15, 14:41

Commit message

With the FormEngine rewrite the evaluation order and handling of the
options changed. This patch restores the previous order, adds tests
for the addItems handling as well as for the execution order of
keepItems, addItems and removeItems.

In addition the behavior of keepItems with an empty list of items has
been restored.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5