44717[BUGFIX] Correct autosuggest when no result has been found
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Wouter Wolters +1
- Björn Jacob +1
- Oliver Eglseder +1
- Michael Oehlhof +1
-
Verified V +2
- Georg Ringer +2
- Wouter Wolters +1
- Björn Jacob +1
- Oliver Eglseder +1
- Michael Oehlhof +1
Issues 1
Files 2
Review log 20
-
Markus Sommer uploaded patch set 1 11/14/15, 13:53
-
Markus Sommer updated the commit message in patch set 2 11/14/15, 13:55
-
Björn Jacob commented on patch set 3 11/14/15, 16:57
Published edit on patch set 2 -
Björn Jacob commented on patch set 3 CR +1 V +1 11/14/15, 16:57
Very nice. -
Oliver Eglseder voted on patch set 3 CR +1 V +1 11/14/15, 22:33
-
Michael Oehlhof commented on patch set 3 11/15/15, 00:11
Can't reproduce the bug with current master. In 7LTS it is still there. Don't know if this patch is really needed. -
Wouter Wolters commented on patch set 3 CR -1 11/15/15, 13:50
_topbar.less:190inline styles -
Wouter Wolters uploaded patch set 4 11/15/15, 13:51
-
Wouter Wolters commented on patch set 4 CR +1 V +1 11/15/15, 13:52
reproducable by typing something that has no hits at all. If you have a result and than no results the view is correct. -
Stefan Neufeind commented on patch set 4 11/15/15, 15:41
Tried to replicate the problem. But with the patch, turning the new !important rule on/off in FireBug didn't result in a difference as I expected. Hmm ... -
Björn Jacob commented on patch set 4 CR +1 V +1 11/15/15, 15:51
Tested with current chrome. Problem can still be reproduced on Chrome, Opera and Firefox. -
Oliver Eglseder commented on patch set 4 CR +1 V +1 11/15/15, 17:47
I can still reproduce this and the patch works fine -
Steffen Müller commented on patch set 4 11/15/15, 20:28
Can't reproduce on latest chrome and firefox -
Daniel L commented on patch set 4 11/15/15, 20:55
Can't reproduce the error on latest chromium and firefox (ubuntu 15.10). Patch has no effect. -
Marcus Schwemer commented on patch set 4 V -1 11/15/15, 21:10
Cannot reproduce this too. Updated the issue in order to get more information about the environment. Until more info my -1, because there is probably no change. -
Björn Jacob commented on patch set 4 11/15/15, 21:19
This little basta*d is quite annoying, isn't it... -
Michael Oehlhof voted on patch set 4 CR +1 V +1 11/15/15, 22:13
-
Marcus Schwemer voted on patch set 4 V 0 11/20/15, 13:10
-
Georg Ringer voted on patch set 4 CR +2 V +2 11/20/15, 13:15
-
Gerrit merged patch set 4 11/20/15, 13:15