Review main Merged

44775[TASK] Installtool: display maximum allowed file size for uploads

Josef Glatz CR +2 V +2 Easy +1 −0 updated 11/23/15, 09:43

Commit message

Since the maximum file size for uploaded files is only limited by
PHP, we could add information about the actually allowed file
size for uploads.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Frank Nägler +1
  • Verified V +2
    • Andreas Kienast +2
    • Frank Nägler +1

Issues 1

Files 1

Review log 13

  1. Josef Glatz uploaded patch set 1 11/18/15, 18:59

  2. Josef Glatz commented on patch set 1 CR -1 11/18/15, 19:00

    Will push a RST file for docu a little bit later
  3. Josef Glatz uploaded patch set 2 11/18/15, 21:41

  4. Michael Oehlhof voted on patch set 2 CR +1 V +1 11/18/15, 21:53

  5. Gianluigi Martino voted on patch set 2 V +1 11/19/15, 09:20

  6. Frank Nägler voted on patch set 2 CR +1 11/20/15, 10:36

  7. Markus Sommer voted on patch set 2 CR +1 V +1 11/20/15, 14:31

  8. Andreas Kienast commented on patch set 2 11/20/15, 15:30

    tbh, I'm not sure whether this is actually a feature, but a task instead.
  9. Josef Glatz commented on patch set 3 11/22/15, 21:44

    Published edit on patch set 2
  10. Josef Glatz rebased onto patch set 3 11/23/15, 05:30

  11. Frank Nägler voted on patch set 4 CR +1 V +1 11/23/15, 09:40

  12. Andreas Kienast voted on patch set 4 CR +2 V +2 11/23/15, 09:43

  13. Gerrit merged patch set 4 11/23/15, 09:43