Review main Merged

44806[BUGFIX] Check if popup window is there before focusing it

Markus Klein CR +2 V +2 Easy +3 −1 updated 11/19/15, 19:47

Commit message

A popup might be blocked by the browser. Check if the window
is really available before putting focus to it to avoid a JS error.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Valentin Despa +1
    • Helmut Hummel +1
  • Verified V +2
    • Anja Leichsenring +2
    • Helmut Hummel +1

Issues 1

Files 1

Review log 6

  1. Markus Klein uploaded patch set 1 11/19/15, 19:15

  2. Helmut Hummel voted on patch set 1 CR +1 11/19/15, 19:17

  3. Valentin Despa commented on patch set 1 CR +1 11/19/15, 19:21

    Code-Review okay.
  4. Helmut Hummel voted on patch set 1 V +1 11/19/15, 19:34

  5. Anja Leichsenring voted on patch set 1 CR +2 V +2 11/19/15, 19:47

  6. Gerrit merged patch set 1 11/19/15, 19:47