44976[FEATURE] Make new content element wizard tab sort order configurable
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Alexander Stehlik +1
-
Verified V +2
- Markus Klein +2
- Alexander Stehlik +1
Issues 1
Files 2
Review log 18
-
Christian Weiske uploaded patch set 1 11/27/15, 10:48
-
Mathias Brodala commented on patch set 1 CR -1 11/27/15, 10:59
Please implement this using the DependencyOrderingService instead. This would allow for a more flexible approach like "...wizardItems.special.position.before = common" -
Christian Weiske uploaded patch set 2 11/27/15, 11:28
-
Christian Weiske updated the commit message in patch set 3 11/27/15, 11:28
-
Josef Glatz commented on patch set 2 11/27/15, 11:30
It's a feature, you need to add a documentation rst file (-> https://forger.typo3.org/standard/rst) -
Christian Weiske uploaded patch set 4 11/27/15, 11:36
-
Mathias Brodala commented on patch set 4 11/27/15, 11:47
NewContentElementController.php:415These 4 lines could be reduced by moving the repeating parts into a protected helper method. -
Christian Weiske uploaded patch set 5 11/27/15, 12:23
-
Christian Weiske uploaded patch set 6 11/27/15, 12:56
-
Georg Ringer voted on patch set 6 CR +1 V +1 01/15/16, 21:56
-
Markus Klein voted on patch set 6 CR +2 V +2 01/15/16, 22:01
-
Markus Klein wrote 01/15/16, 22:09
Patch set 7: Published edit on patch set 6. -
Markus Klein wrote 01/15/16, 22:09
Patch set 8: Commit message was updated. -
Markus Klein commented on patch set 8 CR -1 01/15/16, 22:17
Using the config from the rst I get: Uncaught TYPO3 Exception #1381960494: Your dependencies have cycles. That will not work out. Cycles found: special.->special. I need to check that -
Markus Klein commented on patch set 8 CR +1 V +1 01/15/16, 23:18
Funny mistake of mine with pasting LF into the TSconfig field and save+close => leading to one line of config instead of two. All good. Thanks. -
Alexander Stehlik voted on patch set 8 CR +1 V +1 01/15/16, 23:51
-
Markus Klein voted on patch set 8 CR +2 V +2 01/16/16, 00:11
-
Gerrit merged patch set 8 01/16/16, 00:12