Review main Merged

45048[TASK] EXT:lang Add a litle space between the search field and the table

Michael Oehlhof CR +2 V +2 Easy +1 −0 updated 12/04/15, 15:31

Commit message

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Benni Mack +1
  • Verified V +2
    • Wouter Wolters +2
    • Ralf Merz +1
    • Benni Mack +1

Issues 1

Files 1

Review log 6

  1. Michael Oehlhof uploaded patch set 1 11/29/15, 11:47

  2. Ralf Merz commented on patch set 1 CR -1 12/04/15, 14:07

    See comment. I think we should not use a br-tag, but do this via CSS.

    ListLanguages.html:18

    A "br" helps to get a little space quickly, but I think this should be done via CSS.
  3. Benni Mack commented on patch set 1 CR +1 V +1 12/04/15, 15:22

    it's the same as in em, so that's totally fine with me IMHO
  4. Ralf Merz commented on patch set 1 CR 0 V +1 12/04/15, 15:25

    Ok, if you´re fine with that br, it´s ok. I don´t know the "best practice" for the backend markup.
  5. Wouter Wolters voted on patch set 1 CR +2 V +2 12/04/15, 15:30

  6. Gerrit merged patch set 1 12/04/15, 15:31