Review main Merged

45211[BUGFIX] ExportPageTreeView wrapTitle() signature is incompatible

Markus Sommer CR +2 V +2 Easy +4 −2 updated 12/11/15, 19:45

Commit message

ExportPageTreeView contains following method declaration:

 public function wrapTitle($title, $v);

however in the AbstractTreeView the signature is:

 public function wrapTitle($title, $row, $bank = 0);

This will create a PHP warning on PHP7.

This change updates the method signature of the ExportPageTreeView to be
in line with the AbstractTreeView.

Review

  • Code review CR +2
    • Morton Jonuschat +2
    • Andreas Kienast +1
  • Verified V +2
    • Morton Jonuschat +2
    • Andreas Kienast +1

Issues 1

Files 1

Review log 12

  1. Markus Sommer uploaded patch set 1 12/11/15, 13:14

  2. Markus Sommer uploaded patch set 2 12/11/15, 13:15

  3. Michael Oehlhof commented on patch set 2 12/11/15, 13:37

    I don't get the error described in the item with current master. How to reproduce it?
  4. Andreas Kienast commented on patch set 2 12/11/15, 13:41

    Is this related to PHP 7?
  5. Markus Sommer commented on patch set 2 12/11/15, 13:50

    i can only reproduce this on php7
  6. Michael Oehlhof commented on patch set 2 12/11/15, 14:09

    Tested local with php 5.6.10. Additionally tested on a hosting server with php 7.0.0 and TYPO3 master (GIT revision f0f1dob) but no error occurred. Maybe also depending on the content to be exported?
  7. Morton Jonuschat uploaded patch set 3 12/11/15, 19:20

  8. Morton Jonuschat commented on patch set 3 CR +1 V +1 12/11/15, 19:21

    Verified on OS X / PHP 5.6.10 (no warning before or after Patch), Debian 8.2 / PHP 7.0.0 (warning gone after patch)
  9. Andreas Kienast commented on patch set 4 12/11/15, 19:42

    Published edit on patch set 3
  10. Andreas Kienast voted on patch set 4 CR +1 V +1 12/11/15, 19:42

  11. Morton Jonuschat voted on patch set 4 CR +2 V +2 12/11/15, 19:45

  12. Gerrit merged patch set 4 12/11/15, 19:45