Review main Merged

45348[TASK] Optimize FormEngineValidation, Part I

Andreas Kienast CR +2 V +2 Normal +29 −42 updated 12/30/15, 18:02

Commit message

The implementation of FormEngineValidation has been improved at some parts:

- The parsed integer value in FormEngineValidation.formatValue is now
stored in a variable to prevent parsing the same value multiple times.

- The `nospace` evaluation has been improved: Instead of checking each
character, a regex is applied.

- The `ltrim` and `btrim` implementations are now regex based. There are
already native JavaScript implementations, but not supported by every
browser.

- parseInt does now really a parseInt() call and checks for NaN.

- The dirty state of the form is now stored in a variable after changing
a field, the DOM is not traversed after clicking "Close" anymore.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2