Review main Merged

4536[BUGFIX] 'Update settings' button does not work in new em

Susi Moog CR +2 V +2 Easy +1 −2 updated 06/03/13, 20:49

Commit message

After installing an extension you get a popup where you can
update the configuration settings of an extension. In the new
extension manager the update button there will not work as it
is a submit button but the form around the fields is missing.

Attached patch simply inserts the form in this case, too.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Björn Pedersen +1
    • Philipp Gampe +1
  • Verified V +2
    • Christian Kuhn +2
    • Philipp Gampe +1

Issues 1

Files 1

Review log 7

  1. Björn Pedersen commented on patch set 1 08/26/11, 20:39

    Looks good to me, but someone else must approve
  2. Christian Kuhn commented on patch set 1 08/26/11, 20:39

    Verified; Looks good to me, but someone else must approve
  3. Christian Kuhn commented on patch set 1 08/26/11, 20:39

    Easy to test: It is the bottom left button as shown in the screenshot attached to the forge issue.
  4. Philipp Gampe commented on patch set 1 08/26/11, 20:39

    Verified; Looks good to me, but someone else must approve
  5. Mr. Jenkins commented on patch set 1 08/26/11, 20:39

  6. Christian Kuhn commented on patch set 1 V 0 08/26/11, 20:39

    by team member; Looks good to me, approved
  7. Christian Kuhn merged patch set 1 08/26/11, 20:39