Review main Merged

45939[TASK] Deprecate more methods of DocumentTemplate

Georg Ringer CR +2 V +2 Easy +42 −0 updated 01/15/16, 15:26

Commit message

Unused and to be deprecated methods:

- wrapInCData
- funcMenu
- getDragDropCode
- getTabMenu
- getVersionSelector

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Oliver Klee +1
    • Markus Klein +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Issues 1

Files 2

Review log 10

  1. Georg Ringer uploaded patch set 1 01/15/16, 13:12

  2. Michael Oehlhof commented on patch set 1 01/15/16, 13:24

    Deprecation-72733-DeprecateMoreMethodsOfDocumentTemplate.rst:20

    This "with" is needless, I think.
  3. Markus Klein wrote 01/15/16, 13:35

    Patch set 2: Published edit on patch set 1.
  4. Markus Klein voted on patch set 2 CR +1 V +1 01/15/16, 13:35

  5. Oliver Klee commented on patch set 2 01/15/16, 13:40

    No lawyers, please! Unsued -> unused
  6. Oliver Klee wrote 01/15/16, 13:40

    Patch set 3: Commit message was updated.
  7. Oliver Klee voted on patch set 3 CR +1 01/15/16, 13:40

  8. Markus Klein voted on patch set 3 CR +1 V +1 01/15/16, 13:51

  9. Wouter Wolters voted on patch set 3 CR +2 V +2 01/15/16, 15:26

  10. Gerrit merged patch set 3 01/15/16, 15:26